damccorm commented on PR #35473:
URL: https://github.com/apache/beam/pull/35473#issuecomment-3258257708
Looks like the coverage failure here is probably a real issue. We probably
need the same change there that we're making to the examples workflow.
```
<testcase
classname="apache_beam.examples.snippets.transforms.elementwise.enrichment_test.EnrichmentTest"
name="test_enrichment_with_google_cloudsql_pg" time="2.420">
<failure message="TypeError: str expected, not NoneType">self =
<apache_beam.examples.snippets.transforms.elementwise.enrichment_test.EnrichmentTest
testMethod=test_enrichment_with_google_cloudsql_pg> mock_stdout =
<_io.StringIO object at 0x781158679f70> def
test_enrichment_with_google_cloudsql_pg(self, mock_stdout): db_adapter =
DatabaseTypeAdapter.POSTGRESQL > with
EnrichmentTestHelpers.sql_test_context(True, db_adapter):
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:147: _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/contextlib.py:119: in
__enter__ return next(self.gen)
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:203: in
sql_test_context result = EnrichmentTestHelpers.pre_sql_enrichment_test(
apache_beam/examples/snippets/transforms/elementwise/enrichment_test.py:246: in
pre_sql_enrichment_test os.environ['GOOGLE_CLOUD_SQL_DB_PASSWORD'] = p
assword /opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/os.py:684: in
__setitem__ value = self.encodevalue(value) _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ value = None def encode(value): if
not isinstance(value, str): > raise TypeError("str expected, not %s" %
type(value).__name__) E TypeError: str expected, not NoneType
/opt/hostedtoolcache/Python/3.9.22/x64/lib/python3.9/os.py:756:
TypeError</failure>
</testcase>
```
Rather than bundling those changes with this PR, lets make them in a
separate PR so that we can confirm all tests pass here. Added
https://github.com/apache/beam/pull/36061 to do this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
