damccorm commented on code in PR #36001:
URL: https://github.com/apache/beam/pull/36001#discussion_r2310378485
##########
sdks/python/apache_beam/runners/direct/direct_runner.py:
##########
@@ -202,9 +201,17 @@ def visit_transform(self, applied_ptransform):
# Use BundleBasedDirectRunner if other runners are missing needed features.
runner = BundleBasedDirectRunner()
+ # Check if transform overrides are needed - if so,
+ # use BundleBasedDirectRunner
+ # since Prism does not support transform overrides
+ transform_overrides = _get_transform_overrides(options)
+ if transform_overrides:
Review Comment:
Why do we need to apply these overrides in Prism?
If we're applying an override, it is usually because some feature is not
included which is needed for the transform - it seems like it would be better
to just exclude prism when the feature itself is needed vs assuming all
transforms with overrides don't work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
