damccorm commented on code in PR #36001:
URL: https://github.com/apache/beam/pull/36001#discussion_r2316413564
##########
sdks/python/apache_beam/runners/direct/direct_runner.py:
##########
@@ -202,9 +201,17 @@ def visit_transform(self, applied_ptransform):
# Use BundleBasedDirectRunner if other runners are missing needed features.
runner = BundleBasedDirectRunner()
+ # Check if transform overrides are needed - if so,
+ # use BundleBasedDirectRunner
+ # since Prism does not support transform overrides
+ transform_overrides = _get_transform_overrides(options)
+ if transform_overrides:
Review Comment:
> I think this is a better approach because then the basic pubsub write
transform works as is and overriding is just for specialization.
I think this is the key thing - ideally you would not need to implement an
override for this to work on arbitrary runners; overrides should be the
exceptional case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
