shunping commented on code in PR #36014:
URL: https://github.com/apache/beam/pull/36014#discussion_r2319345662
##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -690,7 +690,16 @@ def add(self, urn, logical_type):
self.by_language_type[logical_type.language_type()] = logical_type
def get_logical_type_by_urn(self, urn):
- return self.by_urn.get(urn, None)
+ logical_type = self.by_urn.get(urn, None)
Review Comment:
I discussed with @Abacn who initially implemented these JDBC logical types.
We think we can move them in `schemas.py`.
Note that we will inevitably introduce this non-portable piece into
`schemas.py`, either by the import method in the current PR or by moving those
logical types directly into the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
