shunping commented on code in PR #36014:
URL: https://github.com/apache/beam/pull/36014#discussion_r2319658873


##########
sdks/python/apache_beam/typehints/schemas.py:
##########
@@ -690,7 +690,16 @@ def add(self, urn, logical_type):
     self.by_language_type[logical_type.language_type()] = logical_type
 
   def get_logical_type_by_urn(self, urn):
-    return self.by_urn.get(urn, None)
+    logical_type = self.by_urn.get(urn, None)

Review Comment:
   Nice catch. Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to