damccorm commented on code in PR #36031:
URL: https://github.com/apache/beam/pull/36031#discussion_r2322218161
##########
sdks/python/apache_beam/transforms/external_test.py:
##########
@@ -357,9 +374,9 @@ def test_external_transform_finder_leaf(self):
'beam:transforms:xlang:test:nooutput',
ImplicitSchemaPayloadBuilder({'data': '0'}),
expansion_service.ExpansionServiceServicer()))
- pipeline.run().wait_until_finish()
- self.assertTrue(pipeline.contains_external_transforms)
+ found = has_external(pipeline)
+ self.assertTrue(found, f"No ExternalTransform found; saw: {found}")
Review Comment:
I think this removes the purpose of what we're testing here - we are trying
to make sure that Beam can correctly identify external transforms when we run
it.
##########
sdks/python/apache_beam/transforms/external_test.py:
##########
@@ -357,9 +374,9 @@ def test_external_transform_finder_leaf(self):
'beam:transforms:xlang:test:nooutput',
ImplicitSchemaPayloadBuilder({'data': '0'}),
expansion_service.ExpansionServiceServicer()))
- pipeline.run().wait_until_finish()
- self.assertTrue(pipeline.contains_external_transforms)
+ found = has_external(pipeline)
+ self.assertTrue(found, f"No ExternalTransform found; saw: {found}")
Review Comment:
I think the core problem is that this is running on Prism, but Prism
theoretically should be excluding this -
https://github.com/apache/beam/blob/67eaded97bf0f138efd15cb6fcf38fcdcf41d3cd/sdks/python/apache_beam/runners/direct/direct_runner.py#L148
I'm not sure why it isn't yet, but taking a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
