damccorm commented on code in PR #36031:
URL: https://github.com/apache/beam/pull/36031#discussion_r2322319059
##########
sdks/python/apache_beam/transforms/external_test.py:
##########
@@ -357,9 +374,9 @@ def test_external_transform_finder_leaf(self):
'beam:transforms:xlang:test:nooutput',
ImplicitSchemaPayloadBuilder({'data': '0'}),
expansion_service.ExpansionServiceServicer()))
- pipeline.run().wait_until_finish()
- self.assertTrue(pipeline.contains_external_transforms)
+ found = has_external(pipeline)
+ self.assertTrue(found, f"No ExternalTransform found; saw: {found}")
Review Comment:
Letting tests run now, but I validated
https://github.com/apache/beam/pull/36049 should work locally and I think it is
a better fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
