damccorm commented on code in PR #36251:
URL: https://github.com/apache/beam/pull/36251#discussion_r2379909305
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -354,7 +354,7 @@ def _replace_if_needed(self, original_transform_node):
if replacement_transform is original_transform_node.transform:
return
replacement_transform.side_inputs = tuple(
- original_transform_node.transform.side_inputs)
+ getattr(original_transform_node.transform, 'side_inputs', ()))
Review Comment:
Rather than doing all of these attribute checks, can we just set these
property to empty values when we initialize the object?
https://github.com/apache/beam/blob/0432c225c2d74bb35af952507f34877392f2773c/sdks/python/apache_beam/transforms/ptransform.py#L359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
