liferoad commented on code in PR #36251:
URL: https://github.com/apache/beam/pull/36251#discussion_r2382881723
##########
sdks/python/apache_beam/pipeline.py:
##########
@@ -354,7 +354,7 @@ def _replace_if_needed(self, original_transform_node):
if replacement_transform is original_transform_node.transform:
return
replacement_transform.side_inputs = tuple(
- original_transform_node.transform.side_inputs)
+ getattr(original_transform_node.transform, 'side_inputs', ()))
Review Comment:
I don't know what you mean here. The nested transform misses many fields
(check the rest of my PR), which are not needed when the transform is nested.
My PR can make sure any future nested transform should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
