tvalentyn commented on code in PR #35904: URL: https://github.com/apache/beam/pull/35904#discussion_r2379922229
########## sdks/python/apache_beam/internal/cloudpickle_pickler.py: ########## @@ -29,16 +29,20 @@ import base64 import bz2 +import contextlib import io import logging import sys import threading +from unittest import mock Review Comment: Yes, I think we could forego the context manager and do the unconditional patching. I think that's sufficient for your usecase since for the lifetime of the process the setting is either enabled or disabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
