tvalentyn commented on code in PR #35904: URL: https://github.com/apache/beam/pull/35904#discussion_r2380092124
########## sdks/python/apache_beam/internal/cloudpickle/cloudpickle.py: ########## @@ -111,6 +111,7 @@ class CloudPickleConfig: """Configuration for cloudpickle behavior.""" id_generator: typing.Optional[callable] = uuid_generator skip_reset_dynamic_type_state: bool = False + enable_stable_code_identifier_pickling: bool = False Review Comment: please add description here, and rename the setting ########## sdks/python/apache_beam/internal/cloudpickle_pickler.py: ########## @@ -29,16 +29,20 @@ import base64 import bz2 +import contextlib import io import logging import sys import threading +from unittest import mock import zlib from apache_beam.internal.cloudpickle import cloudpickle +from apache_beam.internal import code_object_pickler DEFAULT_CONFIG = cloudpickle.CloudPickleConfig( - skip_reset_dynamic_type_state=True) + skip_reset_dynamic_type_state=True, + enable_stable_function_identifiers=False) Review Comment: please add description of the setting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
