claudevdm commented on code in PR #36316:
URL: https://github.com/apache/beam/pull/36316#discussion_r2389537442
##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,13 @@ def from_runner_api_parameter(unused_payload, components,
unused_context):
else:
return cls()
+ def version_tag(self) -> str:
+ """Appends a version tag to the coder key in the pipeline proto. Versioning
Review Comment:
Right, a mere presence of this string signals to dataflow runner (or any
runner potentially) that the coder is different. It is not compatible with the
previous coder for this step.
If we change the underlying coder implementation, the runner compatibility
check will not fail (the runner only looks at the coder key/id to determine if
it is compatible.
So adding a version tag to the coder key/id, makes the compat check fail.
Does this make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
