claudevdm commented on code in PR #36316:
URL: https://github.com/apache/beam/pull/36316#discussion_r2389544706


##########
sdks/python/apache_beam/coders/coders.py:
##########
@@ -395,6 +395,13 @@ def from_runner_api_parameter(unused_payload, components, 
unused_context):
       else:
         return cls()
 
+  def version_tag(self) -> str:
+    """Appends a version tag to the coder key in the pipeline proto. Versioning

Review Comment:
   Without this change a new coder needs to be defined in order to change the 
coder key so that compat checks fail like this 
https://github.com/apache/beam/blob/abdec1bcecd16f074a32f75615fca626a8ad4091/sdks/python/apache_beam/coders/coders.py#L919



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to