gemini-code-assist[bot] commented on code in PR #36342:
URL: https://github.com/apache/beam/pull/36342#discussion_r2395307342


##########
sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py:
##########
@@ -53,6 +53,7 @@ def __init__(self, rest_url, options):
     spark_options = options.view_as(pipeline_options.SparkRunnerOptions)
     self._executable_jar = spark_options.spark_job_server_jar
     self._spark_version = spark_options.spark_version
+    self._user_agnet = 
options.view_as(pipeline_options.SetupOptions).user_agent

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   There's a typo in the variable name. It should be `_user_agent` instead of 
`_user_agnet`.
   
   ```suggestion
       self._user_agent = 
options.view_as(pipeline_options.SetupOptions).user_agent
   ```



##########
sdks/python/apache_beam/runners/portability/spark_uber_jar_job_server.py:
##########
@@ -78,7 +79,8 @@ def executable_jar(self):
       else:
         url = job_server.JavaJarJobServer.path_to_beam_jar(
             ':runners:spark:3:job-server:shadowJar')
-    return job_server.JavaJarJobServer.local_jar(url)
+    return job_server.JavaJarJobServer.local_jar(
+        url, user_agent=self._user_agnet)

Review Comment:
   ![high](https://www.gstatic.com/codereviewagent/high-priority.svg)
   
   This variable name has a typo due to its definition earlier in the file. It 
should be `_user_agent`.
   
   ```suggestion
       return job_server.JavaJarJobServer.local_jar(
           url, user_agent=self._user_agent)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to