Abacn commented on code in PR #36342:
URL: https://github.com/apache/beam/pull/36342#discussion_r2394765626
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1716,6 +1716,12 @@ def _add_argparse_args(cls, parser):
help=(
'Docker registry url to use for tagging and pushing the prebuilt '
'sdk worker container image.'))
+ parser.add_argument(
+ '--user_agent',
+ default=None,
Review Comment:
The default is set here:
https://github.com/apache/beam/pull/36342/files#diff-fd140abcfcbb9b91db28c94a0458d02b4eb21f7f61db4935bf501464b27e1cfeR291
if user not setting this value the user agent is set to "Apache Beam Python
SDK/2.xx.0"
The problem of default pipeline options is that Java already has a
--userAgent option defaults to "Apache Beam Java SDK/2.xx.0". This change is
essentially port the option to Python. However Java side default is handled by
a DefaultFactory class, but if I set a non-empty str as default in Python, I
afraid am it could pass to Java side when running portable pipelines / xlang
pipelines, or other unintended result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
