reuvenlax commented on code in PR #36397:
URL: https://github.com/apache/beam/pull/36397#discussion_r2411294961
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TableRowToStorageApiProto.java:
##########
@@ -1137,7 +1137,6 @@ public static TableRow tableRowFromMessage(
boolean includeCdcColumns,
Predicate<String> includeField,
String namePrefix) {
- // TODO: Would be more correct to generate TableRows using setF.
TableRow tableRow = new TableRow();
Review Comment:
Looking at the code, I think it would be better to have tableRowFromMessage
always create list TableRows (in the "f" field) instead of trying to create
maps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
