Abacn commented on code in PR #36397:
URL: https://github.com/apache/beam/pull/36397#discussion_r2414711121
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java:
##########
@@ -3326,6 +3330,20 @@ public Write<T> withWriteTempDataset(String
writeTempDataset) {
return toBuilder().setWriteTempDataset(writeTempDataset).build();
}
+ /**
+ * Enables enhanced table row conversion for better handling of nested
fields and complex data
+ * types. When enabled, uses improved conversion logic that provides
better compatibility with
+ * BigQuery's data model. When disabled (default), uses the legacy
conversion behavior for
+ * backward compatibility.
+ *
+ * @param useEnhancedTableRowConversion true to enable enhanced
conversion, false for legacy
+ * behavior
+ * @return the updated Write transform
+ */
+ public Write<T> withEnhancedTableRowConversion(boolean
useEnhancedTableRowConversion) {
Review Comment:
users on new Beam version could still trigger the bug if not opt-in this
PTransform configuration. Also, this is only used in DLQ in storage_write_api
write methods. Personally prefer over #36425 in terms of fix, and the new tests
added in this PR is valuable and could check in after fix merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
