liferoad commented on code in PR #36390:
URL: https://github.com/apache/beam/pull/36390#discussion_r2403666622


##########
sdks/python/apache_beam/transforms/managed.py:
##########
@@ -193,4 +212,18 @@ def _resolve_expansion_service(
     raise ValueError(
         "No expansion service was specified and could not find a "
         f"default expansion service for {transform_name}: '{identifier}'.")
-  return BeamJarExpansionService(gradle_target)
+
+  # Extract maven_repository_url and user_agent from pipeline options if
+  # available
+  maven_repository_url = None
+  user_agent = None
+  if pipeline_options:
+    from apache_beam.options import pipeline_options as po
+    setup_options = pipeline_options.view_as(po.SetupOptions)
+    maven_repository_url = setup_options.maven_repository_url
+    user_agent = setup_options.user_agent
+
+  return BeamJarExpansionService(

Review Comment:
   I think we need to pass user_agent and maven_repository_url here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to