Abacn commented on code in PR #36390:
URL: https://github.com/apache/beam/pull/36390#discussion_r2417028959
##########
sdks/python/apache_beam/utils/subprocess_server.py:
##########
@@ -404,11 +405,12 @@ def path_to_beam_jar(
_LOGGER.info('Using pre-built snapshot at %s', local_path)
return local_path
- maven_repo = cls.MAVEN_CENTRAL_REPOSITORY
+ maven_repo = maven_repository_url or cls.MAVEN_CENTRAL_REPOSITORY
if 'rc' in version:
# Release candidate
version = version.split('rc')[0]
- maven_repo = cls.MAVEN_STAGING_REPOSITORY
+ if not maven_repository_url:
+ maven_repo = cls.MAVEN_STAGING_REPOSITORY
Review Comment:
not needed in this PR. With custom repository url we can enable `'.dev' in
version:` branch below. May also need `maven_repository_url` to support a file
system path (pass a local maven repo as pipeline option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
