emilymye commented on a change in pull request #12505:
URL: https://github.com/apache/beam/pull/12505#discussion_r489092740
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -357,4 +354,14 @@ private static File zipDirectory(File directory) throws
IOException {
return env;
}
}
+
+ private static String getDefaultJavaSdkHarnessContainerUrl() {
+ String javaVersionId =
+ Float.parseFloat(System.getProperty("java.specification.version")) >=
9 ? "java11" : "java8";
Review comment:
I went ahead and added an Enum to Environments, and removed similar
checks in DataflowRunner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
