emilymye commented on a change in pull request #12505:
URL: https://github.com/apache/beam/pull/12505#discussion_r489887679
##########
File path: website/www/site/content/en/documentation/runtime/environments.md
##########
@@ -116,8 +116,8 @@ By default, no licenses/notices are added to the docker
images.
To examine the containers that you built, run `docker images` from anywhere in
the command line. If you successfully built all of the container images, the
command prints a table like the following:
```
-REPOSITORY TAG IMAGE ID
CREATED SIZE
-apache/beam_java_sdk latest 16ca619d489e 2
weeks ago 550MB
+REPOSITORY TAG IMAGE ID
CREATED SIZE
+apache/beam_java_8sdk latest 16ca619d489e 2
weeks ago 550MB
Review comment:
I went ahead and ran the Kafka example "from local Beam repo" without
specifying the --sdk_harness_container_image_overrides to see if we should pass
the correct URL, which it seems to do (based on the worker container manifest):
```
{
"args": [ ... ],
"image": "apache/beam_java8_sdk:2.25.0.dev",
"imagePullPolicy": "IfNotPresent",
"name": "sdk-1-0",
"volumeMounts": [ {
"mountPath": "/var/opt/google",
"name": "persist"
},
```
Dataflow can't actually grab that container because it doesn't exist (on
hub.docker.com), so the job itself doesn't work, but it seems to be grabbing
the right URL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
