aIbrahiim commented on code in PR #36561:
URL: https://github.com/apache/beam/pull/36561#discussion_r2445307228
##########
sdks/python/apache_beam/transforms/external_test.py:
##########
@@ -66,6 +68,32 @@
# pylint: enable=wrong-import-order, wrong-import-position
+def retry_on_grpc_timeout(max_retries=5, delay=10, max_total_time=300):
Review Comment:
The retry decorator is only applied to specific test methods in
external_test.py, not to the general Beam runtime. but I understand the
concern. I can remove the retry decorators if not needed.
##########
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py:
##########
@@ -416,6 +416,15 @@ def run_stages(
stage_context (translations.TransformContext)
stages (list[fn_api_runner.translations.Stage])
"""
+ # Apply environment configuration for stability
+ force_single_bundle = os.getenv('BEAM_TESTING_FORCE_SINGLE_BUNDLE',
'false').lower() == 'true'
+ deterministic_order = os.getenv('BEAM_TESTING_DETERMINISTIC_ORDER',
'false').lower() == 'true'
Review Comment:
yes right, these variables currently only log. The actual implementation
would need to be added to the execution context to enforce single bundle
execution and ordering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
