damccorm commented on code in PR #36561:
URL: https://github.com/apache/beam/pull/36561#discussion_r2460464209
##########
sdks/python/test-suites/tox/common.gradle:
##########
@@ -35,9 +35,6 @@ test.dependsOn "testPy${pythonVersionSuffix}Dill"
// toxTask "testPy${pythonVersionSuffix}Dask",
"py${pythonVersionSuffix}-dask", "${posargs}"
// test.dependsOn "testPy${pythonVersionSuffix}Dask"
project.tasks.register("preCommitPy${pythonVersionSuffix}") {
- // Since codecoverage reports will always be generated for py39,
- // all tests will be exercised.
Review Comment:
Lets keep the above comment (though line 40 isn't helpful, so we can get rid
of it)
##########
sdks/python/apache_beam/transforms/external_test.py:
##########
@@ -20,13 +20,15 @@
# pytype: skip-file
import dataclasses
+import functools
import logging
import os
import tempfile
+import time
import typing
import unittest
-import mock
+from unittest import mock
Review Comment:
do we need the changes in this file now?
##########
contributor-docs/python-tips.md:
##########
@@ -265,7 +265,31 @@ Execute the following code for running tests using tox:
### Running Tests Using gradle
-Integration tests suites on Jenkins are configured in groovy files that launch
certain gradle tasks
([example](https://github.com/apache/beam/blob/0fd6a044df5b9f26d567e0f9a619a665a0f4043b/.test-infra/jenkins/job_PostCommit_Python.groovy#L43)).
You could launch test suites locally by executing the gradle targets directly
(for example: `./gradlew
:sdks:python:test-suites:dataflow:py39:postCommitPy39`). This option may only
be available to committers, as by default the test suites are configured to use
the
[`apache-beam-testing`](https://github.com/apache/beam/blob/0fd6a044df5b9f26d567e0f9a619a665a0f4043b/sdks/python/scripts/run_integration_test.sh#L70)
project.
+Integration tests suites on Jenkins are configured in groovy files that launch
certain gradle tasks
([example](https://github.com/apache/beam/blob/0fd6a044df5b9f26d567e0f9a619a665a0f4043b/.test-infra/jenkins/job_PostCommit_Python.groovy#L43)).
You could launch test suites locally by executing the gradle targets directly
(for example: `./gradlew
:sdks:python:test-suites:dataflow:py39:postCommitPy39`). This option may only
be available to committers, as by default the test suites are configured to use
the
[`apache-beam-testing`](https://github.com/apache/beam/blob/0fd6a044df5b9f26d567e0f9a619a665a0f4043b/sdks/python/scripts/run_integration_test.sh#L70)
project.
+
+### Environment Variables for Test Stability
+
+The following environment variables can be used to improve test stability in
CI environments:
+
+**Beam-specific settings:**
Review Comment:
I thought we determined that many of these env vars don't actually do
anything, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
