shunping commented on code in PR #36672:
URL: https://github.com/apache/beam/pull/36672#discussion_r2478142809


##########
sdks/go/pkg/beam/runners/prism/internal/engine/elementmanager.go:
##########
@@ -1334,10 +1334,13 @@ func (ss *stageState) injectTriggeredBundlesIfReady(em 
*ElementManager, window t
        }
        state := wv[key]
        endOfWindowReached := window.MaxTimestamp() < ss.input
+       em.refreshCond.L.Lock()
+       emNow := em.ProcessingTimeNow()

Review Comment:
   The problem as I mentioned below 
(https://github.com/apache/beam/pull/36672#issuecomment-3466027378) is about 
the order of obtaining two locks (refreshCond.L and ss.mu) is different in the 
watermark evaluation go routine and the go routine for running `PersistBundle`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to