shunping commented on PR #36672:
URL: https://github.com/apache/beam/pull/36672#issuecomment-3469127155

   > Looks like my fix also caused deadlock:
   > 
   > * In the watermark evaluation loop, we always get `refreshCond.L` first 
and then `ss.mu`.
   > * However, in `PersistBundle()` (a separate Go Routine), when we need to 
`addPending` to aggregate kind, we first obtain `ss.mu`. Then when evaluating 
trigger bundle, we need to obtain `refreshCond.L` for checking processing time 
in the scenario of not using real-time clock.
   
   To resolve the deadlock mentioned here, we will have to make sure 
`refreshCond.L` is acquired before `ss.mu` whenever we need to access 
`em.processTimeEvents`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to