kennknowles commented on code in PR #36581:
URL: https://github.com/apache/beam/pull/36581#discussion_r2486625022
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/JavaBeanUtils.java:
##########
@@ -439,6 +441,13 @@ public ByteCodeAppender appender(final Target
implementationTarget) {
return (methodVisitor, implementationContext, instrumentedMethod) -> {
// this + method parameters.
int numLocals = 1 + instrumentedMethod.getParameters().size();
+ StackManipulation cast =
+ typeInformation
+ .getRawType()
+ .isAssignableFrom(
+
Preconditions.checkNotNull(typeInformation.getMethod()).getReturnType())
Review Comment:
Please avoid `Preconditions.checkNotNull` - we've made better versions.
Please use `checkArgumentNotNull` if the null error should be blamed on the
caller, or `checkStateNotNull` if the null error should be blamed on this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
