gemini-code-assist[bot] commented on code in PR #36534:
URL: https://github.com/apache/beam/pull/36534#discussion_r2499068830
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillKeyedWorkItem.java:
##########
@@ -108,13 +115,22 @@ public Iterable<WindowedValue<ElemT>> elementsIterable() {
Collection<? extends BoundedWindow> windows =
WindmillSink.decodeMetadataWindows(windowsCoder,
message.getMetadata());
PaneInfo paneInfo =
WindmillSink.decodeMetadataPane(message.getMetadata());
+ // Draining value is based on upstream data
+ boolean drainingValueFromUpstream = false;
if (WindowedValues.WindowedValueCoder.isMetadataSupported()) {
- WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
+ BeamFnApi.Elements.ElementMetadata elementMetadata =
+ WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
+ drainingValueFromUpstream =
+ elementMetadata.hasDrain()
+ ? (elementMetadata.getDrain()
+ == BeamFnApi.Elements.DrainMode.Enum.DRAINING)
+ : false;
Review Comment:
This logic for determining `drainingValueFromUpstream` can be simplified.
Since `elementMetadata.getDrain()` returns the default enum value
`NOT_DRAINING` if the field isn't set, the explicit `hasDrain()` check and
ternary operator are unnecessary.
Additionally, this logic is duplicated in `UngroupedWindmillReader.java`.
Consider extracting it into a shared helper method (e.g., in `WindmillSink`) to
improve maintainability.
```java
drainingValueFromUpstream =
elementMetadata.getDrain() ==
BeamFnApi.Elements.DrainMode.Enum.DRAINING;
```
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/UngroupedWindmillReader.java:
##########
@@ -117,8 +118,14 @@ protected WindowedValue<T> decodeMessage(Windmill.Message
message) throws IOExce
Collection<? extends BoundedWindow> windows =
WindmillSink.decodeMetadataWindows(windowsCoder,
message.getMetadata());
PaneInfo paneInfo =
WindmillSink.decodeMetadataPane(message.getMetadata());
+ boolean drainingValueFromUpstream = false;
if (WindowedValues.WindowedValueCoder.isMetadataSupported()) {
- WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
+ BeamFnApi.Elements.ElementMetadata elementMetadata =
+ WindmillSink.decodeAdditionalMetadata(windowsCoder,
message.getMetadata());
+ drainingValueFromUpstream =
+ elementMetadata.hasDrain()
+ ? (elementMetadata.getDrain() ==
BeamFnApi.Elements.DrainMode.Enum.DRAINING)
+ : false;
Review Comment:
This logic for determining `drainingValueFromUpstream` can be simplified.
Since `elementMetadata.getDrain()` returns the default enum value
`NOT_DRAINING` if the field isn't set, the explicit `hasDrain()` check and
ternary operator are unnecessary.
Additionally, this logic is duplicated in `WindmillKeyedWorkItem.java`.
Consider extracting it into a shared helper method (e.g., in `WindmillSink`) to
improve maintainability.
```java
drainingValueFromUpstream =
elementMetadata.getDrain() ==
BeamFnApi.Elements.DrainMode.Enum.DRAINING;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
