scwhittle commented on code in PR #36534:
URL: https://github.com/apache/beam/pull/36534#discussion_r2549800770
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/UngroupedWindmillReader.java:
##########
@@ -129,11 +134,19 @@ protected WindowedValue<T> decodeMessage(Windmill.Message
message) throws IOExce
T result =
(T) KV.of(decode(kvCoder.getKeyCoder(), key),
decode(kvCoder.getValueCoder(), data));
// todo #33176 propagate metadata to windowed value
- return WindowedValues.of(result, timestampMillis, windows, paneInfo);
+ return WindowedValues.of(
+ result, timestampMillis, windows, paneInfo, null, null,
drainingValueFromUpstream);
Review Comment:
should we be merging in the getDrainMode() bit from the context?
when is it encoded in the metadata versus set in the context?
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/WindmillTimerInternals.java:
##########
@@ -395,6 +398,7 @@ public static TimerData windmillTimerToTimerData(
timestamp,
outputTimestamp,
timerTypeToTimeDomain(timer.getType()));
+ // todo add draining
Review Comment:
add issue for tracking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
