ktalluri456 commented on code in PR #36737:
URL: https://github.com/apache/beam/pull/36737#discussion_r2500894361
##########
sdks/python/apache_beam/runners/worker/operations.py:
##########
@@ -444,12 +445,19 @@ def __init__(
self.metrics_container = MetricsContainer(self.name_context.metrics_name())
self.state_sampler = state_sampler
- self.scoped_start_state = self.state_sampler.scoped_state(
- self.name_context, 'start', metrics_container=self.metrics_container)
- self.scoped_process_state = self.state_sampler.scoped_state(
- self.name_context, 'process', metrics_container=self.metrics_container)
- self.scoped_finish_state = self.state_sampler.scoped_state(
- self.name_context, 'finish', metrics_container=self.metrics_container)
+ if self.state_sampler:
Review Comment:
While I was debugging CI failures, I noticed that the state_sampler is None
when operations are run in a non-streaming context. The autocomplete_test was
an example of this.
Adding the Noop state ensures that the code is safe to execute in all
contexts, both for the new timer metric and or the existing start, process, and
finish states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
