tvalentyn commented on code in PR #36737:
URL: https://github.com/apache/beam/pull/36737#discussion_r2511879272
##########
sdks/python/apache_beam/runners/worker/operations.py:
##########
@@ -808,8 +816,14 @@ def __init__(
self.user_state_context = user_state_context
self.tagged_receivers = None # type: Optional[_TaggedReceivers]
# A mapping of timer tags to the input "PCollections" they come in on.
+ # Force clean rebuild
Review Comment:
Let's not forget to remove this. Note: you can close and reopen PRs to rerun
a test suite.
##########
sdks/python/apache_beam/runners/worker/operations.py:
##########
@@ -444,12 +445,19 @@ def __init__(
self.metrics_container = MetricsContainer(self.name_context.metrics_name())
self.state_sampler = state_sampler
- self.scoped_start_state = self.state_sampler.scoped_state(
- self.name_context, 'start', metrics_container=self.metrics_container)
- self.scoped_process_state = self.state_sampler.scoped_state(
- self.name_context, 'process', metrics_container=self.metrics_container)
- self.scoped_finish_state = self.state_sampler.scoped_state(
- self.name_context, 'finish', metrics_container=self.metrics_container)
+ if self.state_sampler:
Review Comment:
I have tried reverting this branch and running the autocomplete test. it
didn't fail.
Let me try running the test suite without this branch. I'd like to
understand why this is necessary.
##########
sdks/python/apache_beam/runners/worker/statesampler_test.py:
##########
@@ -127,6 +127,41 @@ def test_sampler_transition_overhead(self):
# debug mode).
self.assertLess(overhead_us, 20.0)
+ @retry(reraise=True, stop=stop_after_attempt(3))
Review Comment:
ok, will take a look. let's remove this though since it is redundant in any
case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
