stankiewicz commented on code in PR #36534:
URL: https://github.com/apache/beam/pull/36534#discussion_r2550714841
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcWindmillServerTest.java:
##########
@@ -469,12 +471,14 @@ public void onCompleted() {
(String computation,
@Nullable Instant inputDataWatermark,
Instant synchronizedProcessingTime,
+ boolean drainMode,
WorkItem workItem,
long serializedWorkItemSize,
ImmutableList<LatencyAttribution> getWorkStreamLatencies) -> {
assertEquals(inputDataWatermark, new Instant(18));
assertEquals(synchronizedProcessingTime, new Instant(17));
assertEquals(workItem.getKey(),
ByteString.copyFromUtf8("somewhat_long_key"));
+ assertTrue(drainMode);
Review Comment:
@kennknowles I've expanded tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
