claudevdm commented on code in PR #36892:
URL: https://github.com/apache/beam/pull/36892#discussion_r2582777086
##########
sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java:
##########
@@ -1186,6 +1196,9 @@ private static org.apache.avro.Schema getFieldSchema(
} else if (SqlTypes.TIMESTAMP.getIdentifier().equals(identifier)) {
baseType =
LogicalTypes.timestampMicros().addToSchema(org.apache.avro.Schema.create(Type.LONG));
+ } else if (Timestamp.IDENTIFIER.equals(identifier)) {
+ baseType = org.apache.avro.Schema.create(Type.LONG);
+ baseType.addProp("logicalType", TIMESTAMP_NANOS_LOGICAL_TYPE);
Review Comment:
I left it intentionally for now, because the only Timestamp logical type we
use in BQ io currently is nanos. micros and millis are covered by
[https://github.com/apache/beam/blob/21109328f725bb9136316455db07507144df719f/sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java#L1186
and
](https://github.com/apache/beam/blob/21109328f725bb9136316455db07507144df719f/sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java#L1140)
and
https://github.com/apache/beam/blob/21109328f725bb9136316455db07507144df719f/sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java#L1186
I can add a note explaining this, or we can proactively map those beam types
to avro types (although this work doesnt require that)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
