claudevdm commented on code in PR #36892:
URL: https://github.com/apache/beam/pull/36892#discussion_r2582804682
##########
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtilsTest.java:
##########
@@ -549,6 +550,88 @@ public void testFromBeamSchema() {
assertEquals(getAvroSchema(), avroSchema);
}
+ @Test
+ public void testBeamTimestampNanosLogicalTypeToAvroSchema() {
+ Schema beamSchema =
+ Schema.builder().addLogicalTypeField("timestampNanos",
Timestamp.NANOS).build();
+
+ // Expected Avro schema with timestamp-nanos
+ String expectedJson =
+ "{\"type\": \"record\", \"name\": \"topLevelRecord\", "
+ + "\"fields\": [{\"name\": \"timestampNanos\", "
+ + "\"type\": {\"type\": \"long\", \"logicalType\":
\"timestamp-nanos\"}}]}";
+
+ org.apache.avro.Schema expectedAvroSchema =
+ new org.apache.avro.Schema.Parser().parse(expectedJson);
+
+ assertEquals(expectedAvroSchema, AvroUtils.toAvroSchema(beamSchema));
+ }
+
+ @Test
+ public void testBeamTimestampNanosToGenericRecord() {
+ Schema beamSchema =
+ Schema.builder().addLogicalTypeField("timestampNanos",
Timestamp.NANOS).build();
+
+ java.time.Instant instant =
java.time.Instant.parse("2000-01-01T01:02:03.123456789Z");
+ Row beamRow = Row.withSchema(beamSchema).addValue(instant).build();
+
+ // Expected nanos since epoch
+ long expectedNanos = TimeUnit.SECONDS.toNanos(instant.getEpochSecond()) +
instant.getNano();
+
+ org.apache.avro.Schema avroSchema = AvroUtils.toAvroSchema(beamSchema);
+ GenericRecord avroRecord = AvroUtils.toGenericRecord(beamRow, avroSchema);
+
+ assertEquals(expectedNanos, avroRecord.get("timestampNanos"));
+ }
+
+ @Test
+ public void testTimestampNanosRoundTrip() {
+ Schema beamSchema =
+ Schema.builder().addLogicalTypeField("timestampNanos",
Timestamp.NANOS).build();
+
+ // Test various nanosecond precisions
+ java.time.Instant[] testInstants = {
+ java.time.Instant.parse("2000-01-01T00:00:00.000000001Z"), // 1 nano
+ java.time.Instant.parse("2000-01-01T00:00:00.123456789Z"), // full nanos
+ java.time.Instant.parse("2000-01-01T00:00:00.999999999Z"), // max nanos
+ java.time.Instant.ofEpochSecond(0L, Long.MAX_VALUE), // max supported
+ java.time.Instant.ofEpochSecond(0L, Long.MIN_VALUE), // min supported
Review Comment:
Doesnt java.time.Instant.ofEpochSecond(0L, Long.MIN_VALUE) cover what you
are mentioning? This will be the earliest date supported (something like
1677-09-210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
