gemini-code-assist[bot] commented on code in PR #36986:
URL: https://github.com/apache/beam/pull/36986#discussion_r2586791882
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java:
##########
@@ -373,7 +411,23 @@ private static FieldType fromTableFieldSchemaType(
case "BOOL":
return FieldType.BOOLEAN;
case "TIMESTAMP":
- return FieldType.DATETIME;
+ // Timestamp columns can only have 6 or 12 precision.
+ if ((schema.getTimestampPrecision() == null) ||
(schema.getTimestampPrecision() == 6)) {
Review Comment:
The comparison `schema.getTimestampPrecision() == 6` can be fragile as it
compares a `Long` object with an `int` primitive. While it may work in many
cases due to auto-unboxing, it's safer and better practice to use `.equals()`
for object comparisons to avoid potential issues with `Long` caching and object
identity. For example, `new Long(6) == new Long(6)` would be false. Using
`Long.valueOf(6L).equals(schema.getTimestampPrecision())` is more robust.
```suggestion
if (schema.getTimestampPrecision() == null ||
Long.valueOf(6L).equals(schema.getTimestampPrecision())) {
```
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TimestampPrecision.java:
##########
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.bigquery;
+
+/** Speciefies Timestamp precision. */
Review Comment:
There is a typo in the Javadoc. 'Speciefies' should be 'Specifies'.
```suggestion
/** Specifies Timestamp precision. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
