Abacn commented on code in PR #36986: URL: https://github.com/apache/beam/pull/36986#discussion_r2594065293
########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/TimestampPrecision.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.gcp.bigquery; + +/** Specifies Timestamp precision. */ +public enum TimestampPrecision { Review Comment: Consider point to BigQuery API's TableFieldSchema.getTimestampPrecision documentation ########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java: ########## @@ -350,14 +385,17 @@ static StandardSQLTypeName toStandardSQLTypeName(FieldType fieldType) { * * <p>Supports both standard and legacy SQL types. * - * @param typeName Name of the type returned by {@link TableFieldSchema#getType()} + * @param schema Schema of the type returned * @param nestedFields Nested fields for the given type (eg. RECORD type) * @return Corresponding Beam {@link FieldType} */ private static FieldType fromTableFieldSchemaType( Review Comment: We now pass the whole TableFieldSchema. It also contains nestedFields (schema.getFields()). To avoid potential mixed use of two sources of nestedFields, either remove the second parameter, or add a overload method fromTableFieldSchemaType(TableFieldSchema schema, SchemaConversionOptions options) ########## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryUtils.java: ########## @@ -373,7 +411,24 @@ private static FieldType fromTableFieldSchemaType( case "BOOL": return FieldType.BOOLEAN; case "TIMESTAMP": - return FieldType.DATETIME; + // Timestamp columns can only have 6 or 12 precision. + if ((schema.getTimestampPrecision() == null) + || Long.valueOf(6L).equals(schema.getTimestampPrecision())) { Review Comment: I saw a test "testFromTableSchema_timestampNullPrecision_defaultsToDatetime" noted that null getTimestampPrecision was for backward compatibility. Is this also the case for `schema.getTimestampPrecision() == 6`? Sounds confusing anyways (FieldType.DATETIME only has millis precision) Any chance to maintain maximum compatibility while respect schema.getTimestampPrecision (e.g. upgrade_compatibility flag etc)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
