damccorm commented on code in PR #37046:
URL: https://github.com/apache/beam/pull/37046#discussion_r2600130949
##########
sdks/python/tox.ini:
##########
@@ -87,12 +87,12 @@ commands_pre =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands =
python apache_beam/examples/complete/autocomplete_test.py
- bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}"
+ bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '--reruns 1
--reruns-delay 5'
[testenv:py{310,311,312,313}-win]
commands =
python apache_beam/examples/complete/autocomplete_test.py
- bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}"
+ bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '--reruns 1
--reruns-delay 5'
Review Comment:
Nit: If we're going to do this for every invocation, we should include it as
part of the run_pytest.sh script itself
##########
sdks/python/tox.ini:
##########
@@ -87,12 +87,12 @@ commands_pre =
bash {toxinidir}/scripts/run_tox_cleanup.sh
commands =
python apache_beam/examples/complete/autocomplete_test.py
- bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}"
+ bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '--reruns 1
--reruns-delay 5'
Review Comment:
While I understand the pragmatic nature of this fix, I'm not sure it is the
right approach. Doing this has a high likelihood of masking real failures, and
generally I think we should be tracking down/fixing flakes. If there are things
that innately mean we're going to have this level of flakiness, we're likely
passing those on to users as well.
I'm open to more discussion here, but at a minimum I think if we're going to
make a change like this it should be surfaced to the dev list, and probably
should come with data that describes the problem and the reason we have this
kind of flakiness. We could also evaluate alternate approaches there (for
example, reducing the number of tests we run to reduce flakiness, only doing
this for PR runs, etc...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
