shunping commented on code in PR #37046:
URL: https://github.com/apache/beam/pull/37046#discussion_r2600185535


##########
sdks/python/tox.ini:
##########
@@ -87,12 +87,12 @@ commands_pre =
   bash {toxinidir}/scripts/run_tox_cleanup.sh
 commands =
   python apache_beam/examples/complete/autocomplete_test.py
-  bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}"
+  bash {toxinidir}/scripts/run_pytest.sh {envname} "{posargs}" '--reruns 1 
--reruns-delay 5'

Review Comment:
   My rationale for this approach was based on PR #35915, where pytest retry 
arguments were introduced:
   
https://github.com/apache/beam/pull/35915/files#diff-33fb11ecf72212eda83aaf8e36f94816ad447d8d12896dc3b5e5ac3727adbbd1R114,
   even though there are no actual effects for those arguments after my 
investigation. 
   
   I misinterpreted the acceptance of that PR as a general agreement to use 
retries for flaky tests and tried to fix the retry here.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to