chadrik commented on a change in pull request #12881:
URL: https://github.com/apache/beam/pull/12881#discussion_r491597504
##########
File path: sdks/python/apache_beam/utils/urns.py
##########
@@ -177,7 +178,7 @@ def to_runner_api(self, context):
@classmethod
def from_runner_api(cls, fn_proto, context):
- # type: (beam_runner_api_pb2.FunctionSpec, PipelineContext) -> Any
+ # type: (Type[RunnerApiFnT], beam_runner_api_pb2.FunctionSpec,
PipelineContext) -> RunnerApiFnT
Review comment:
This change indicates that we should return an instance of the class
that this is called from, though it provides no runtime guarantees of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
