chadrik commented on a change in pull request #12881: URL: https://github.com/apache/beam/pull/12881#discussion_r491600011
########## File path: sdks/python/apache_beam/runners/worker/data_plane.py ########## @@ -243,7 +274,7 @@ def output_stream( instruction_id, # type: str transform_id # type: str ): - # type: (...) -> ClosableOutputStream + # type: (...) -> SizeBasedBufferingClosableOutputStream Review comment: `ClosableOutputStream` seems to not actually be used anywhere any more, because `ClosableOutputStream.create()` returns `SizeBasedBufferingClosableOutputStream`. `ClosableOutputStream` does not implement the necessary `maybe_flush` method that's required everywhere we were referring to `ClosableOutputStream` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org