claudevdm commented on code in PR #37071: URL: https://github.com/apache/beam/pull/37071#discussion_r2677800708
########## sdks/python/apache_beam/typehints/row.py: ########## @@ -0,0 +1,76 @@ +# Review Comment: A row is not really a typehint, the corresponding typehint already exists in https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/row_type.py. Maybe a better place to move this is sdks/python/apache_beam/utils, e.g. see https://github.com/apache/beam/blob/8801afdbd321d6de4a9dca23f0416b125a8ff14e/sdks/python/apache_beam/utils/timestamp.py ########## sdks/python/apache_beam/typehints/row.py: ########## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import NamedTuple +# Ensure Row schema support is registered even for empty pipelines. +from apache_beam.typehints import schemas # pylint: disable=unused-import Review Comment: Can you please explain more the reasoning behind this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
