nikitagrover19 commented on code in PR #37071: URL: https://github.com/apache/beam/pull/37071#discussion_r2681797692
########## sdks/python/apache_beam/typehints/row.py: ########## @@ -0,0 +1,76 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +from typing import NamedTuple +# Ensure Row schema support is registered even for empty pipelines. +from apache_beam.typehints import schemas # pylint: disable=unused-import Review Comment: I added this import intentionally for its side effects. While testing, I noticed that some empty-pipeline cases (for example CoGroupByKey on an empty PCollection under the PortableRunner) rely on schema support being registered at import time, rather than being triggered by data flowing through the pipeline. Moving Row out of pvalue.py changed when that schema initialization happens, which only shows up in these empty-pipeline scenarios. Importing apache_beam.typehints.schemas here ensures that schema support is registered early and consistently. This doesn’t change behavior for normal (non-empty) pipelines, but helps keep behavior consistent after the refactor. Please let me know if there’s a more appropriate place for this initialization — happy to adjust. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
