methodmissing commented on pull request #12794: URL: https://github.com/apache/beam/pull/12794#issuecomment-696391542
Thanks for the feedback and the merge Luke. I'll address the updates in a PR. I agree all tests makes more sense as one can never have enough coverage. That said, I'm been thinking about the `ConsumerSpEL` and the fact the in the test suite it until now only executed against Kafka clients API 1.0.0 (`library.java.kafka_clients`) for each run. It's possible to also have the tasks and configurations dynamically created for a range of Kafka API versions too now that a pattern emerged, but that also would add quite a lot of time to test runs. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
