lukecwik commented on a change in pull request #12794:
URL: https://github.com/apache/beam/pull/12794#discussion_r492248577
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -64,4 +69,24 @@ dependencies {
testCompile library.java.powermock_mockito
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
+ kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+}
+
+configurations.kafkaVersion210 {
+ resolutionStrategy {
+ force "org.apache.kafka:kafka-clients:2.1.0"
+ }
+}
+
+task kafkaVersion210Test(type: Test) {
+ group = "Verification"
+ description = 'Runs KafkaIO tests with Kafka clients API 2.1.0'
+ outputs.upToDateWhen { false }
+ testClassesDirs = sourceSets.test.output.classesDirs
+ classpath = configurations.kafkaVersion210 +
sourceSets.test.runtimeClasspath
+ include '**/KafkaIOTest.class'
Review comment:
Can we run all the unit tests?
```suggestion
include '**/KafkaIOTest.class'
```
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -64,4 +69,24 @@ dependencies {
testCompile library.java.powermock_mockito
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
+ kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+}
+
+configurations.kafkaVersion210 {
+ resolutionStrategy {
+ force "org.apache.kafka:kafka-clients:2.1.0"
+ }
+}
+
+task kafkaVersion210Test(type: Test) {
+ group = "Verification"
+ description = 'Runs KafkaIO tests with Kafka clients API 2.1.0'
+ outputs.upToDateWhen { false }
Review comment:
Instead of doing `outputs.upToDateWhen { false }` to have this run every
time, please include the set of inputs/outputs that makes sense in a follow-up
PR so that an incremental build can be supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
