GlobalStar117 commented on PR #37352: URL: https://github.com/apache/beam/pull/37352#issuecomment-3771624053
@Eliaaazzz Thank you for the detailed clarification! You're absolutely right. I initially implemented the fix using `DoFnSignature` as the cache key, but reverted it after encountering CI test failures. I incorrectly concluded that the current behavior was correct due to type erasure. Your explanation makes it clear that the issue is real: - While `Class<?>` is the same at runtime due to type erasure - `DoFnSignature` captures the `TypeDescriptor` information that users can override via `getInputTypeDescriptor()` - The generated invoker needs this type information for correct serialization (Coders) and schema verification I'll re-implement the original fix using `DoFnSignature` as the cache key and investigate the test failures more carefully. The previous CI failure in `ParDoTest$TimerTests` may have been a pre-existing flaky test rather than something my change caused. Let me push the corrected fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
