GlobalStar117 commented on PR #37352:
URL: https://github.com/apache/beam/pull/37352#issuecomment-3771630256

   @Eliaaazzz I've updated the PR with the proper fix:
   
   ✅ **Changed cache key from `Class<?>` to `DoFnSignature`**
   
   This ensures that:
   - DoFns with the same raw class but different `TypeDescriptor`s (via 
`getInputTypeDescriptor()` override) receive separate invokers
   - Correct serialization (Coders) and schema verification for each type 
configuration
   
   The previous implementation documented the `Class<?>` behavior as 'correct 
due to type erasure' - but as you explained, that was wrong because Apache 
Beam's `DoFnSignature` captures the `TypeDescriptor` information that's 
critical for proper invoker generation.
   
   Thank you for the clarification - it helped me understand the deeper issue!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to