tvalentyn commented on code in PR #37350:
URL: https://github.com/apache/beam/pull/37350#discussion_r2708672468
##########
sdks/python/apache_beam/io/gcp/bigquery_test.py:
##########
@@ -723,7 +723,7 @@ def test_read_export_exception(self, exception_type,
error_message):
'Insert') as mock_query_job, \
mock.patch('time.sleep'), \
self.assertRaises(Exception) as exc,\
- beam.Pipeline() as p:
+ beam.Pipeline(runner='DirectRunner') as p:
Review Comment:
I would try to look at the following:
1. which runner is selected when we don't specify 'runner' parameter
explicitly, and why (b/c it is not a good state to have unsolved mysteries). I
didn't expect the setting `runner=DirectRunner` to have an effect.
2. does prism runner support these tests? if so, why it is not being used.
3. we might still have to solve the core problem of tuning grpc for our test
suites, i don't think switching to bundlebased direct runner is a viable option
long term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
