damccorm commented on code in PR #37350:
URL: https://github.com/apache/beam/pull/37350#discussion_r2709418732
##########
sdks/python/apache_beam/io/gcp/bigquery_test.py:
##########
@@ -723,7 +723,7 @@ def test_read_export_exception(self, exception_type,
error_message):
'Insert') as mock_query_job, \
mock.patch('time.sleep'), \
self.assertRaises(Exception) as exc,\
- beam.Pipeline() as p:
+ beam.Pipeline(runner='DirectRunner') as p:
Review Comment:
Yeah, I agree with Valentyn. There are some tests which pin to the
FnApiRunner (e.g.
https://github.com/apache/beam/blob/600bd612dc2ef495fef08675398361159f7a03df/sdks/python/apache_beam/yaml/yaml_specifiable_test.py#L62)
but those are for pretty specific reasons. In general, we should be using the
default direct runner for almost all of our local tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
