ATHARVA262005 commented on code in PR #37402:
URL: https://github.com/apache/beam/pull/37402#discussion_r2721915147
##########
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java:
##########
@@ -2308,13 +2308,17 @@ public void testBatchGroupIntoBatchesOverrideBytes() {
@Test
public void testBatchGroupIntoBatchesWithShardedKeyOverrideCount() throws
IOException {
PipelineOptions options = buildPipelineOptions();
+ // Ignore this test for streaming pipelines.
+ assumeFalse(options.as(StreamingOptions.class).isStreaming());
Pipeline p = Pipeline.create(options);
verifyGroupIntoBatchesOverrideCount(p, true, true);
}
@Test
public void testBatchGroupIntoBatchesWithShardedKeyOverrideBytes() throws
IOException {
PipelineOptions options = buildPipelineOptions();
+ // Ignore this test for streaming pipelines.
+ assumeFalse(options.as(StreamingOptions.class).isStreaming());
Review Comment:
I was checking options.as(StreamingOptions.class) on a newly created options
object (which defaults to batch), so the check was never triggering. I’ve
updated the code to use pipeline.getOptions(), which uses the actual
configuration from the test runner (so if the test suite says "run as
streaming", pipeline.getOptions() will reflect that).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
