ATHARVA262005 commented on code in PR #37402:
URL: https://github.com/apache/beam/pull/37402#discussion_r2721921160
##########
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowRunnerTest.java:
##########
@@ -2308,13 +2308,17 @@ public void testBatchGroupIntoBatchesOverrideBytes() {
@Test
public void testBatchGroupIntoBatchesWithShardedKeyOverrideCount() throws
IOException {
PipelineOptions options = buildPipelineOptions();
+ // Ignore this test for streaming pipelines.
+ assumeFalse(options.as(StreamingOptions.class).isStreaming());
Review Comment:
Thank you for the catch! You are absolutely right—checking
`options.as(StreamingOptions.class).isStreaming()` on the locally created keys
creates a fresh options instance that defaults to batch, meaning the check
would never trigger.
I have updated the PR to use
`assumeFalse(pipeline.getOptions().as(StreamingOptions.class).isStreaming());`.
This uses the `TestPipeline` rule's options, which correctly reflects the test
execution environment (e.g., if the suite is running in streaming mode).
The fix has been pushed to the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
