shunping commented on code in PR #37379:
URL: https://github.com/apache/beam/pull/37379#discussion_r2737558986
##########
sdks/python/container/boot.go:
##########
@@ -503,3 +514,21 @@ func logSubmissionEnvDependencies(ctx context.Context,
bufLogger *tools.Buffered
bufLogger.Printf(ctx, "%s", string(content))
return nil
}
+
+// MakePipelineOptionsFileAndEnvVar writes the pipeline options to a file.
+// Assumes the options string is JSON formatted.
+//
+// Stores the file name in question in PIPELINE_OPTIONS_FILE for access by the
SDK.
+func MakePipelineOptionsFileAndEnvVar(options string) (string, error) {
Review Comment:
Any reason to redefine this function? I see we already have that at
https://github.com/apache/beam/blob/928ad7e2aab52ce5bd36895bae1d17bd9d8d5124/sdks/go/container/tools/pipeline_options.go#L28,
and we already imported the Go package in this `boot.go` at
https://github.com/apache/beam/blob/928ad7e2aab52ce5bd36895bae1d17bd9d8d5124/sdks/python/container/boot.go#L38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
